Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom duotone menu has disappeared #58548

Open
webexpr-dhenriet opened this issue Feb 1, 2024 · 11 comments
Open

Custom duotone menu has disappeared #58548

webexpr-dhenriet opened this issue Feb 1, 2024 · 11 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Testing Needs further testing to be confirmed. [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Bug An existing feature does not function as intended

Comments

@webexpr-dhenriet
Copy link

webexpr-dhenriet commented Feb 1, 2024

Description

Impossible to create a specific duotone.
I can only choose from the duotones available.
The creation menu has disappeared.
In theme.json settings.color.customDuotone is set to true.

Step-by-step reproduction instructions

  • admin
  • select image, duotone

Screenshots, screen recording, code snippet

Screenshot_5

Environment info

  • WP 6.4.3

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@webexpr-dhenriet webexpr-dhenriet added the [Type] Bug An existing feature does not function as intended label Feb 1, 2024
@jordesign jordesign added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Testing Needs further testing to be confirmed. labels Feb 1, 2024
@carolinan
Copy link
Contributor

Hi
I am not able to reproduce this.
I am getting different results depending on if Gutenberg 17.6 is active and wether I am using a classic theme.
But the custom selector works in all my tests.

customDuotone defaults to true, so you don't need it in theme.json.
https://developer.wordpress.org/block-editor/reference-guides/theme-json-reference/theme-json-living/#color

On WordPress 6.4.3 or 6.3.3:
Classic theme, Twenty Twenty: The custom duotone selector works, but the WordPress default Duotones are not available.
Twenty Twenty-Four: Site Editor and post editor: The custom duotone selector work, the theme duotones work, and the WordPress default Duotones are not available. The theme has "defaultDuotone": false,.

On WordPress 6.4.3, or 6.3.3 with Gutenberg 17.6 active:
Classic theme, Twenty Twenty: The custom duotone selector work, and the WordPress default Duotones work.
Twenty Twenty-Four: Site Editor and post editor: The custom duotone selector work, the theme duotones work, and the WordPress default Duotones are not available. The theme has "defaultDuotone": false,.

On WordPress 6.5 alpha
Classic theme, Twenty Twenty: The custom duotone selector work, and the WordPress default Duotones work
Twenty Twenty-Four: Site Editor and post editor: The custom duotone selector work, the theme duotones work, and the WordPress default Duotones are not available. The theme has "defaultDuotone": false,.

@webexpr-dhenriet
Copy link
Author

webexpr-dhenriet commented Feb 2, 2024

@carolinan thanks for your feddback.
I am using a custom hybrid theme (PHP,theme.json) without Gutenberg plugin. I'll try to clear this up as soon as I have a bit of time.

It's just an ux problem.
It seems to me that the custom duotone used to be accessible from the right-hand sidebar.
This custom duotone menu (shadow) is only accessible from the top bar of the element.
Has this changed?


301776572-deaaedd3-f15c-482e-a1fa-873e19ee02a9

301776596-f34587da-2e3d-44fc-bc62-84d8fdf27cb3

@graylaurenm
Copy link
Contributor

I'm seeing the same in my custom Block theme. I have "defaultDuotone": false, and typically am able to create custom duotones with my color palette (I have the default and custom color options disabled). I do not have the Gutenberg plugin installed, so this is from the core update imo. I may be able to provide more detailed troubleshooting tomorrow.

@carolinan
Copy link
Contributor

Hmm you know what, I only tested the toolbar option. I will try to find the time to do another round of testing.

@graylaurenm
Copy link
Contributor

I can replicate this in a fresh WordPress install using TT4. The toolbar has custom duotone options, the sidebar block styles do not.

Correct:
Screenshot 2024-02-04 at 8 54 01 AM

Missing:
Screenshot 2024-02-04 at 8 53 53 AM

@t-hamano
Copy link
Contributor

I was able to reproduce the problem mentioned in this comment in TT4.

  • Reproduced in WordPress 6.5 Beta1.
  • Reproduced on WordPress 6.5 Beta1 with Gutenberg version 17.7.0 enabled.
  • Reproduced in WordPress6.4.3.
  • Reproduced not only with image blocks but also with the cover block.

What I can think of from this is that the custom duotone settings may not have been taken into account in the block sidebar.

@t-hamano
Copy link
Contributor

I did some more research and found that the current behavior may be intentional, as seen in #55361. (see this comment)

I hacked this code to temporarily enable custom colors, and they work for individual blocks. However, in the Global Styles, they don't work for blocks.

dfc4b9b391c2182a52ee5ddad3435fc8.mp4

@ajlende @MaggieCabrera Is it possible to enable the custom duotone in the block sidebar as in the block toolbar, but leave the custom duotone disabled at the global style block level?

Copy link

Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Mar 17, 2024
@webexpr-dhenriet
Copy link
Author

I'am still experiencing this issue with the latest versions.

@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Mar 19, 2024
Copy link

Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Apr 19, 2024
@webexpr-dhenriet
Copy link
Author

I'am still experiencing this issue with the latest versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Testing Needs further testing to be confirmed. [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants