-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency with showing + icon on block library #5919
Comments
This is not related to inserter states, but the button that opens it. I believe the cases where it's not shown is because the hover style on the trailing inserter don't apply when the inserter is opened. |
Showing on the Blocks tab, but not showing on Shared or search. I'd be down with either not showing on all of those or showing. |
|
@karmatosed @mtias Let me know if we need reverse of my solution means when the search box is in focus, hide all icons. Thanks! |
@vishalkakadiya thanks for working on a PR, in this case I don't think we need to hide the icons. The issue right now isn't just on search, the states don't show the same on the tab also. I am not sure opacity is the solution here, or at least just on search it is. |
@karmatosed That PR will solve an issue for all states, and as per my debugging it looks like opacity issue only. |
@karmatosed @mtias Let me know if any updates needed on my PR, I will do that right away. Thanks! |
@karmatosed #6090 is the refreshed PR for it. Thanks! |
Closing as this has now been added, thanks! |
In the various states of the block library you either see the + or don't. I would suggest it should show for all states perhaps?
The text was updated successfully, but these errors were encountered: