Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency with showing + icon on block library #5919

Closed
karmatosed opened this issue Apr 1, 2018 · 9 comments
Closed

Inconsistency with showing + icon on block library #5919

karmatosed opened this issue Apr 1, 2018 · 9 comments
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.

Comments

@karmatosed
Copy link
Member

In the various states of the block library you either see the + or don't. I would suggest it should show for all states perhaps?

2018-04-01 at 13 00

@karmatosed karmatosed added the [Feature] Blocks Overall functionality of blocks label Apr 1, 2018
@gziolo gziolo added [Type] Enhancement A suggestion for improvement. Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Apr 1, 2018
@mtias
Copy link
Member

mtias commented Apr 2, 2018

This is not related to inserter states, but the button that opens it. I believe the cases where it's not shown is because the hover style on the trailing inserter don't apply when the inserter is opened.

@karmatosed
Copy link
Member Author

karmatosed commented Apr 2, 2018

Showing on the Blocks tab, but not showing on Shared or search. I'd be down with either not showing on all of those or showing.

@vishalkakadiya
Copy link
Contributor

issue-5919
@karmatosed @mtias I have open PR #5934 for showing all with same opacity when the search box is in the focus.

@vishalkakadiya
Copy link
Contributor

vishalkakadiya commented Apr 2, 2018

@karmatosed @mtias Let me know if we need reverse of my solution means when the search box is in focus, hide all icons.

Thanks!

@karmatosed
Copy link
Member Author

karmatosed commented Apr 3, 2018

@vishalkakadiya thanks for working on a PR, in this case I don't think we need to hide the icons. The issue right now isn't just on search, the states don't show the same on the tab also. I am not sure opacity is the solution here, or at least just on search it is.

@vishalkakadiya
Copy link
Contributor

@karmatosed That PR will solve an issue for all states, and as per my debugging it looks like opacity issue only.

@vishalkakadiya
Copy link
Contributor

vishalkakadiya commented Apr 9, 2018

@karmatosed @mtias Let me know if any updates needed on my PR, I will do that right away. Thanks!

@vishalkakadiya
Copy link
Contributor

@karmatosed #6090 is the refreshed PR for it. Thanks!

@karmatosed
Copy link
Member Author

Closing as this has now been added, thanks!

jasmussen pushed a commit that referenced this issue May 1, 2018
In PR #6090 (much appreciated), #5919 was fixed. However this particular fix introduced a regression where the side plus was now visible right at the start, which it wasn't in 2.7.

This PR takes a different approach, fixing the same issue but without the regression.
jasmussen added a commit that referenced this issue May 1, 2018
In PR #6090 (much appreciated), #5919 was fixed. However this particular fix introduced a regression where the side plus was now visible right at the start, which it wasn't in 2.7.

This PR takes a different approach, fixing the same issue but without the regression.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants