Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Pick script fails on missing merge_commit_sha in Github API response #59398

Open
getdave opened this issue Feb 27, 2024 · 3 comments
Open
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Bug An existing feature does not function as intended

Comments

@getdave
Copy link
Contributor

getdave commented Feb 27, 2024

During Cherry Picing for WP 6.5 Beta 3 the npm run other:cherry-pick script kept failing with:

Error: Cannot fetch the merge commit sha for #XXXXX

The API request is to https://api.github.com/repos/wordpress/gutenberg/pulls/XXXX.

I check the code and it will fail if merge_commit_sha is not in the response.

Performing this manually using a REST client, I could see that merge_commit_sha was included in the response. So for some reason when running using the script it doesn't include that field for certain PRs.

It seems this field may have been deprecated so we may need to find a better method.

@getdave getdave added [Type] Bug An existing feature does not function as intended Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Feb 27, 2024
@getdave
Copy link
Contributor Author

getdave commented Feb 27, 2024

@gziolo Do you have any idea about this one?

cc @youknowriad for information.

@gziolo
Copy link
Member

gziolo commented Feb 27, 2024

Actually, it's @adamziel who authored the script, so he would be a better person to help here.

@adamziel
Copy link
Contributor

adamziel commented Mar 4, 2024

I'm as surprised as you @getdave as this never came up for me before. It seems like we may need a better method than relying on merge_commit_sha indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants