Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Link: Mark removal as not persistant #59676

Open
scruffian opened this issue Mar 7, 2024 · 0 comments
Open

Navigation Link: Mark removal as not persistant #59676

scruffian opened this issue Mar 7, 2024 · 0 comments
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@scruffian
Copy link
Contributor

What problem does this address?

In #57756 we added an onClose event to the LinkUI, which removes the block when the popover closes if the URL is empty. This creates an undo level, so if you undo after this the block is readded, which is surprising.

What is your proposed solution?

We should mark these changes as not persistent so that the undo levels aren't set.

@scruffian scruffian added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block labels Mar 7, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant