Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce @since tags in /packages/block-serialization-default-parser/ and other files #59826

Closed
anton-vlasenko opened this issue Mar 13, 2024 · 0 comments · Fixed by #60007
Closed

Enforce @since tags in /packages/block-serialization-default-parser/ and other files #59826

anton-vlasenko opened this issue Mar 13, 2024 · 0 comments · Fixed by #60007
Assignees
@anton-vlasenko
Labels
[Type] Code Quality Issues or PRs that relate to code quality

Comments

@anton-vlasenko
Copy link
Contributor

anton-vlasenko commented Mar 13, 2024 •
edited
Loading

What problem does this address?

This issue is a follow-up from #55777.
@since tags are not enforced in .php files in the following directories:

  • /packages/block-serialization-default-parser/.+/*\.php$
  • widgets/src/blocks/legacy-widget/index.php
  • widgets/src/blocks/widget-group/index.php

Props to @gziolo.

Original discussion: #59700 (comment)

What is your proposed solution?

These files may contain PHP classes, so the FunctionCommentSinceTagSniff sniff has to be modified to work with class methods too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anton-vlasenko anton-vlasenko

Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
1 participant
@anton-vlasenko