-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts: Deprecated or remove Puppeteer as e2e test handler #60357
Comments
I think it should be ok to remove and mark the change as breaking change. People will have to update the package manually anyway. That said, we need to answer the fact that some people would want to continue using puppeteer while updating scripts package. In that case, I think it's a documentation thing. It should be possible to install puppeteer and run it directly for them without needing us to provide it in wp-scripts. |
We could update the This seems like the right place to do it. gutenberg/packages/scripts/scripts/test-e2e.js Lines 31 to 37 in 6accdd3
|
Shouldn't we update test-e2e to use playwright instead? and if we detect puppeteer tests somehow render the upgrade guide? |
That would be nice, but we need to figure out how to detect puppeteer tests. I guess if we're going for a breaking change, we could:
|
Extracted from #59311.
Now that core is fully migrated to Playwright and is the recommended library for running e2e tests, let's consider gracefully deprecating or fully removing Puppeteer from the scripts package.
The text was updated successfully, but these errors were encountered: