Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.6.0] Exp Columns - Shortcode columns no longer wrapped with div .layout-column-1 class #6042

Closed
opicron opened this issue Apr 6, 2018 · 3 comments
Assignees
Labels
[Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Type] Bug An existing feature does not function as intended

Comments

@opicron
Copy link

opicron commented Apr 6, 2018

On 2.5.0 shortcode columns in experimental columns block are wrapped in a div with the class layout-column-1. In 2.6.0 this no longer seems to be the case.

@paulwilde
Copy link
Contributor

See #5935 and #5351.

@aduth
Copy link
Member

aduth commented Apr 6, 2018

When you say "wrapped", do you mean in the markup saved for the post, or as shown in the editor?

@aduth
Copy link
Member

aduth commented Apr 6, 2018

Nevermind, I was able to reproduce. I think this was a subtle change introduced in #5897 where we're no longer applying a div wrapper to RawHTML contents. It was originally this way because blocks apply a default set of props, including classname, and otherwise there is nothing to which to apply the props. RawHTML should include the wrapper for these cases, and otherwise the children verbatim.

@aduth aduth added the [Type] Bug An existing feature does not function as intended label Apr 6, 2018
@aduth aduth self-assigned this Apr 6, 2018
@danielbachhuber danielbachhuber added the [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P label Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants