Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color variation: ensure editing color palette is reflected in the UI and changes aren't immediately reverted when clicking the same preset #61462

Closed
annezazu opened this issue May 8, 2024 · 2 comments
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented May 8, 2024

While testing out the early color and typography variations work, I noticed that when editing the preset that the color changes aren't reflected in the preset and, if I click on the same one I'm editing, it overwrites the changes I just made without warning:

color.presets.mov

I'd expect the changes to show up in the UI to the color preset and that clicking the same preset wouldn't just overwrite without a warning. This ties into similar concerns with style variations overwriting changes made.

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] Theme Style Variations Related to style variations provided by block themes labels May 8, 2024
@richtabor
Copy link
Member

I do think this flow is much clearer as implemented in #61213 where the color palettes are in the same view, rather than within a sub-view. If you pull the lastest you should see that flow.

When you choose an alternate color palette, it becomes your palette — which may be edited/manipulated. I don't think we need to warn people that colors are changing, when you change colors.

@annezazu
Copy link
Contributor Author

annezazu commented May 8, 2024

Huzzah! I just went through that new flow and I agree. This is much clearer. Going to close this out. For clarity, here's what it looks like for others following:

new.experience.mov

Thanks for connecting the dots there.

@annezazu annezazu closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants