Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow text orientation by default on any block that has a typography panel #62693

Open
beafialho opened this issue Jun 20, 2024 · 5 comments
Open
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@beafialho
Copy link

Currently, as far as I know, only the Paragraph and Heading blocks can become vertical text. I suggest, as mentioned in #50319 and specifically in this comment, allowing text-orientation by default on any block that has a typography panel. Here's an example of a cool layout we'd be able to achieve below with a vertical Site Title:

site title

@beafialho beafialho added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs labels Jun 20, 2024
@jasmussen jasmussen added the Needs Dev Ready for, and needs developer efforts label Jun 20, 2024
@jasmussen jasmussen moved this to Needs Dev in Design priorities Jun 20, 2024
@MaggieCabrera
Copy link
Contributor

I think adding this to all blocks with a typography panel might be a bit too much. Blocks like the search block, the comments block or the table of contents may not look ok with this setting. I'll start with the ones that make more sense beyond the heading and the paragraph though

@beafialho
Copy link
Author

I think adding this to all blocks with a typography panel might be a bit too much. Blocks like the search block, the comments block or the table of contents may not look ok with this setting. I'll start with the ones that make more sense beyond the heading and the paragraph though

Yes, I understand what you mean and I think the search block probably isn't a good one either, there may be others too. But Site Title, Post Navigation and Buttons for instance sound like some good ones to start.

@genepine
Copy link

Hi
When I set the typography text to vertical in the WordPress 6.7.1 editing screen, I can't move between characters with the cursor keys.
Image
Image

*If multiple lines of vertical text are lined up, the vertical text will be lined up vertically. (Maybe I didn't think about this enough.)
This requires specifying vertical text for the group block and specifying that the effect should be applied to the paragraphs contained within.

If I leave the text horizontal in the editing screen and specify vertical text in CSS, I can move between characters with the cursor keys.
Image
Image

bandicam.2024-11-28.21-44-21-957.mp4

@t-hamano
Copy link
Contributor

Hi @genepine, thanks for the report.

This issue is for discussing enhancements. For bugs, Could you fsubmit a new issue?

@genepine
Copy link

@t-hamano
Thanks guiding me,

I submit a new issue.
#67394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
Status: Needs Dev
Development

No branches or pull requests

5 participants