Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleGroupControl: allow option items to be accessible when disabled #63612

Open
ciampo opened this issue Jul 16, 2024 · 0 comments
Open

ToggleGroupControl: allow option items to be accessible when disabled #63612

ciampo opened this issue Jul 16, 2024 · 0 comments
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Comments

@ciampo
Copy link
Contributor

ciampo commented Jul 16, 2024

While #63450 added support in ToggleGroupControl for disabled option items, one aspect that could still be improved is to make disabled option items accessible when disabled, similarly to how the Toolbar and Tabs component behave.

The challenge in doing so is how to visually let the user know where the keyboard focus is VS what item is currently selected.

In #63450 we tried a few approaches, but none of them was convincing enough.

It's also worth mentioning that we already solved this challenge in Tabs:

  • we show a focus ring to indicate where keyboard focus is (even on disabled tabs)
  • we use an underline to indicate the currently selected tab
Kapture.2024-07-16.at.11.50.48.mp4

But applying the same treatment to ToggleGroupControl is tricky because the indicator is a full-height backdrop and would visually clash/overlap with the focus ring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

1 participant