Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typesets section renders a list of installed fonts #63940

Closed
matiasbenedetto opened this issue Jul 25, 2024 · 7 comments · Fixed by #64515
Closed

Typesets section renders a list of installed fonts #63940

matiasbenedetto opened this issue Jul 25, 2024 · 7 comments · Fixed by #64515
Labels
[Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Comments

@matiasbenedetto
Copy link
Contributor

matiasbenedetto commented Jul 25, 2024

What?

I'm seeing this in Gutenberg trunk after merging this PR #62539. I don't think this is the intended behaviour. It seems like typesets is just rendering the list of the installed fonts and not the font families variations:

Screencast.from.25-07-24.10.28.47.webm

Expected:

Render a list of font families styles variations.


Originally in #62539 (comment)

@matiasbenedetto matiasbenedetto added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Typography Font and typography-related issues and PRs labels Jul 25, 2024
@scruffian
Copy link
Contributor

scruffian commented Jul 25, 2024

I think it's working as expected! @richtabor what do you think?

@richtabor
Copy link
Member

It seems like typesets is just rendering the list of the installed fonts and not the font families variations

TT4 does not have any typesets, correct?

@matiasbenedetto
Copy link
Contributor Author

To be honest, I'm not sure what is a 'typeset'. I suppose that that term refers to the list of fonts defines by a style variation. If that's true TT4 has a few theme style variations including different font families but they are not listed in the typeset screen.

@richtabor
Copy link
Member

richtabor commented Jul 26, 2024

Style variations that are comprised on only typography rules, like these. Just like alternate color palettes, but for typography.

@matiasbenedetto
Copy link
Contributor Author

I'm not sure If I understand. TT4 has style variations with different font families. Should they be considered as 'typesets' or not?

@richtabor
Copy link
Member

They must be typography-only, to be considered. This is from the Assembler theme:

CleanShot 2024-07-26 at 12 23 51

@matiasbenedetto
Copy link
Contributor Author

I submitted this PR to hide the typesets button when there are not typesets available: #64515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants