Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize Border Block Support Keys for WP 6.8 #64312

Open
2 of 6 tasks
ndiego opened this issue Aug 6, 2024 · 8 comments
Open
2 of 6 tasks

Stabilize Border Block Support Keys for WP 6.8 #64312

ndiego opened this issue Aug 6, 2024 · 8 comments
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Package] Block library /packages/block-library [Type] Iteration Scoped iteration of an effort from a tracking issue or overview issue ideally for a major release.

Comments

@ndiego
Copy link
Member

ndiego commented Aug 6, 2024

Related to:

Borrowing from the format of #63001, this issue outlines the tasks needed to stabilize the __experimentalBorder support. Doing so will make it easier for third-party extenders to confidently build custom blocks that provide border support and modify existing blocks with this support.

Note that in order to provide backward compatibility for block plugins out in the wild, fallback support for the existing __experimental prefix should be provided.

Stabilize the following border block support and associated properties:

  • __experimentalBorderborder
  • __experimentalBorder.colorborder.color
  • __experimentalBorder.radiusborder.radius
  • __experimentalBorder.styleborder.style
  • __experimentalBorder.widthborder.width

Tasks

  • Update PHP block support code in lib/block-supports/border.php to use the non __experimental prefix
  • Update the JS implementations of the border block supports to point to the non __experimental prefix
  • Update the block.json schema to support the non __experimental prefix
  • Update the core blocks' block.json files to use the non __experimental prefixes
  • Update the supports documentation to include a section for border support.
  • Update the block.json schema to remove the __experimental prefix. Note that the code in WordPress should still support the __experimental prefix, but at this stage, the experimental prefix will be treated as deprecated.

The PR for this stabilization effort should follow the approach used to stabilize the typography supports in #63401.

@ndiego ndiego added [Package] Block library /packages/block-library [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Iteration Scoped iteration of an effort from a tracking issue or overview issue ideally for a major release. labels Aug 6, 2024
@hbhalodia
Copy link
Contributor

Hi @ndiego, I would like to work on the issue.

Thank You,

@hbhalodia
Copy link
Contributor

Hi @ndiego, I have created a draft PR - #64330, but I am seeing this PR needs lots of refactoring once the main referenced PR - #63401 is merged and working. This is because we can use a lot of things from the PR so we do not have redundant code issue happening.

Also, there are ongoing discussion happening on the typography supports stabilization, hence I am aiming to wait for the typography support stabilizing to get merged in trunk and then we can pick up the pace on this issue with the PR.

Though, I have once concern about the border supports, as the whole border is defined as experimental and not the inner supports, so if you can look at quickly on the PR if that is the way we can achieve to stabilize the border and have some initial feedbacks on the approach.

Thank You,

@ndiego
Copy link
Member Author

ndiego commented Aug 7, 2024

@hbhalodia yes, any PR for this issue should follow the similar approach outlined in #63401. I would also recommend waiting until that PR is successfully merged.

@hbhalodia
Copy link
Contributor

hbhalodia commented Aug 7, 2024

Thanks for the response, we can wait until #63401 PR gets merged.

@hadamlenz
Copy link

suspense! I hope it'll be backward compatible

@gziolo gziolo mentioned this issue Oct 10, 2024
69 tasks
@gziolo gziolo changed the title Stabilize border block support keys Stabilize Border Block Support Keys for WP 6.8 Oct 10, 2024
@aaronrobertshaw
Copy link
Contributor

#63401 has been merged, so I think we're in a good spot to move forward on the border support stabilization. I've left a review on @hbhalodia's PR, #64330.

I'm happy to pick up any block support stabilization tasks or move the existing efforts forward.

@aaronrobertshaw
Copy link
Contributor

As discussed on #64330, I've spun up a fresh PR (#66918) that expands on the stabilization approach pioneered via #63401. I plan to give it some testing tomorrow and will then flag it as being ready for review.

Kudos and props to @hbhalodia and @benazeer-ben for all their work to date 🙇

I'll close the other open PRs so we can push the latest approach across the line.

@aaronrobertshaw
Copy link
Contributor

Quick update:

There are two PRs around stabilizing block supports ready for extra eyes, testing, and review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Package] Block library /packages/block-library [Type] Iteration Scoped iteration of an effort from a tracking issue or overview issue ideally for a major release.
Projects
Development

No branches or pull requests

4 participants