-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have only one place for transforms #6449
Comments
I would choose to remove the transform button from the toolbar... transforming a block does not feel like a primary action that is used very often, so it probably should only be shown under the ellipsis. Also, it is more clear that transformation options exist in the ellipsis, compared to the singular icon in the toolbar that is easily overlooked as just the icon of the current block (since that is what it looks like aside from the dropdown arrow). I often forget about the button in the toolbar since it does not immediately yell "transformation" to me, since its icon is just the icon of the block. One of the reasons for having the transform button in the toolbar is to make it easier to write textual content quickly. But with Markdown support, slash commands, 2 insert block buttons, the sibling inserter, and the transform options under "More Options", I feel like that button will be rarely used once one of the other methods are learned. On another note, removing the transform button in the toolbar would provide some extra space for another button or two in its place, like maybe a button to insert inline |
@SuperGeniusZeb yeah my feelings are the toolbar is also right one to remove. I am not sure about adding extra buttons in though, I don't think that code formatting for example is a primary action for everyone. As you point out, having the toolbar take up less space is a really nice benefit here. |
@karmatosed Yeah, the |
Now that block settings menu is the only place for transformations, we should make sure it's not too busy. The menu doesn't very gracefully handle shorter viewports, in my experience, so something like a transformations drawer could be in order (I recall this being discussed in the past). cc @karmatosed |
@mcsf hmm interesting do you have some past issues to reference as that could be good to consider? |
@karmatosed: I see #4467, for instance. |
Reopening this issue because the changes that fixed it were reversed in #6566. |
Currently, you can convert multiple Image blocks to a Gallery block via the transforms in the More Options ellipsis menu for multiple block selection. No block toolbar is currently shown; I am guessing this will change when the transforms are removed from More Options? |
Related: #6781 |
Right now we have 2 places for transforming blocks:
I would suggest we reduce this to one place. My initial feelings are to only have it under the ellipsis - although that could be causing discovery issues. Whatever option we go for, we should go with just having one place.
The text was updated successfully, but these errors were encountered: