Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when Redux Devtools is enabled #65072

Open
2 tasks done
kevin940726 opened this issue Sep 5, 2024 · 0 comments
Open
2 tasks done

Errors when Redux Devtools is enabled #65072

kevin940726 opened this issue Sep 5, 2024 · 0 comments
Labels
Developer Experience Ideas about improving block and theme developer experience [Type] Bug An existing feature does not function as intended

Comments

@kevin940726
Copy link
Member

kevin940726 commented Sep 5, 2024

Description

Do we still support Redux Devtools? Either way, Redux Devtools remains a popular browser extension many React developers install. Enabling the extension in Gutenberg sometimes outputs errors in the console even when the user is not directly interacting with the extension.

Uncaught TypeError: t.toString is not a function
    at ae.stringifyFunction (page.bundle.js:1:1448)
    at s (page.bundle.js:1:2855)
    at s (page.bundle.js:1:4383)
    at s (page.bundle.js:1:4383)
    at s (page.bundle.js:1:4383)
    at s (page.bundle.js:1:4383)
    at s (page.bundle.js:1:4383)
    at s (page.bundle.js:1:4383)
    at s (page.bundle.js:1:4383)
    at s (page.bundle.js:1:4383)

What's worse is that it's not clear in the console that it's caused from Redux Devtools.

It's especially confusing for new contributors, who would probably just avoid contributing if they thought that their environment was not supported.

Step-by-step reproduction instructions

  1. Install Redux Devtools in your browser and enable it.
  2. Open the devtools and interact with gutenberg (try selecting an image block for instance), sometimes the Redux Devtools tab doesn't even need to be active.
  3. See some random errors in the console.

Screenshots, screen recording, code snippet

image

Environment info

  • Tested on Brave (or other chromium based browsers) and the latest Redux Devtools from the extension store.

Please confirm that you have searched existing issues in the repo.

  • Yes

I found an old issue but proved that we used to support Redux Devtools.

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@kevin940726 kevin940726 added [Type] Bug An existing feature does not function as intended Developer Experience Ideas about improving block and theme developer experience labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Experience Ideas about improving block and theme developer experience [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant