Modals: patterns selector appears over welcome guide modal

[ramonjd]

Description

The pattern selector modal activates itself with few or no environmental checks when creating a new page.

For new users, the pattern selector will appear over the welcome guide.

The welcome guide is, I assume, a more fundamental introduction to the editor than the pattern selector and therefore should take precedence.

I would expect, rather, the welcome guide to show first. After dismissing the welcome guide only would the patterns selector show.

I'm not quite sure yet, but it might be worthwhile to register open modals through the interface store.

For this specific instance, something like:

// WelcomeGuide component
const { openModal, closeModal } = useDispatch( interfaceStore );
openModal( 'editor/welcome-guide' );
<WelcomeGuide onClose={ onClose } />

// Elsewhere
const welcomeGuideActive = select( interfaceStore ).isModalActive(
    'editor/welcome-guide'
);

Or relocate or remove the intrusive pattern selector modal.

Related

• Patterns: Provide a way for users to opt out of the 'Choose a Pattern' modal when adding a page #56181

Step-by-step reproduction instructions

1. Create a new users or better, a fresh WP install with GB trunk active
2. Delete any preferences in localStorage
3. Create a new page in the post or site editor
4. Witness how the the modal compete for you attention

Screenshots, screen recording, code snippet

Site Editor

2024-09-06.12.12.13.mp4

Post Editor

2024-09-06.11.27.04.mp4

Environment info

• Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

[annezazu]

Somewhat related (or would be nice to improve alongside this): #63947