Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try zooming out when selecting the patterns tab in the inserter #65749

Closed
richtabor opened this issue Sep 30, 2024 · 6 comments · Fixed by #65785
Closed

Try zooming out when selecting the patterns tab in the inserter #65749

richtabor opened this issue Sep 30, 2024 · 6 comments · Fixed by #65785
Assignees
Labels
[Feature] Zoom Out [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

Now that it's clearer how to disengage zoom out, with the toggle in the editor header and double-click, let's try introducing zoom out on pattern tab selection as well. Previously, the concern was about inserting patterns within patterns, but now that you can toggle off zoom out right from the header, to insert patterns wherever, I think it's worth exploring this further.

Inserting sections of a site with zoom out engaged is a much better experience than without, as patterns are stacked consistently—not placed within other columns, groups, etc.

CleanShot 2024-09-30 at 10 58 07

@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Feature] Zoom Out labels Sep 30, 2024
@jeryj
Copy link
Contributor

jeryj commented Sep 30, 2024

If zoom out is not engaged, then we engage zoom out when entering the pattern tab. Do we automatically disengage zoom out when clicking away from the pattern tab?

We’ll need to make sure if zoom out is already engaged when going into patterns that we don’t disengage zoom out when clicking away

@richtabor
Copy link
Member Author

Do we automatically disengage zoom out when clicking away from the pattern tab?

Yes. If you switch back to "Blocks" it zooms back in.

@getdave
Copy link
Contributor

getdave commented Oct 1, 2024

@richtabor just noting that I don't believe this is going to be targeted for 6.7 so I think we can remove from the board. Is that correct?

@draganescu
Copy link
Contributor

draganescu commented Oct 1, 2024

  • Does going to media reset the view or keeps the zoom out view?
  • If zoom out is engaged manually does any action in the inserter disengage it? (closing the inserter, switching to tabs)

@richtabor
Copy link
Member Author

Does going to media reset the view or keeps the zoom out view?

Maintains current zoom state.

If zoom out is engaged manually does any action in the inserter disengage it? (closing the inserter, switching to tabs)

Yes, when switching to Blocks.

Yes, I think when zoomed out and you close the inserter, the canvas should zoom back in. You can get stuck otherwise.

@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.7 Editor Tasks Oct 7, 2024
@getdave
Copy link
Contributor

getdave commented Oct 7, 2024

No need to backport this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Zoom Out [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants