Establish a consistent pattern for navigation buttons that open sub-panels #66448
Labels
Needs Design Feedback
Needs general design feedback.
[Package] Edit Site
/packages/edit-site
[Type] Bug
An existing feature does not function as intended
Description
In the Site editor, some settings panels have sub-panels (drill-down menus in design jargon). The controls to open these sub-panels are usually
NavigationButtonAsItem
components (under the hod it's aNavigator.Button
).Some of these buttons do show a chevron icon to visually communicate they open a drill-down menu. Some don't.
It's not that clear to me what the criteria is to determine which buttons should show a chevron and which ones should not.
There may be reasons why some don't but I'd tend to think a chevron icon adds value as it makes the user experiences more predictable and communicates well what's going to happen when clicking one of these buttons.
There are other minor inconsistencies, for example some of these buttons have a border. Some don't.
I do realize the navigation buttons that are grouped in a set of logically related items need to be styled a bit differently. Still, the lack of a chevron icon introduces inconsistency and doesn't help predictability.
A few examples:
The following navigation buttons show a chevron icon:
The following navigation buttons do not show a chevron icon:
The buttons undeer 'Elements' are particularly confusing to me. They look like the fonts ones above. However, the fonts ones open a modal dialog while the Elements ones open a drill-down menu. They basically look the same, but they do different things.
One more example:
I'd like to propose to use a chevron icon for all the buttons that open a drill-down menu.
Also i'd suggest to consider some more consistency about borders and margins.
Step-by-step reproduction instructions
N/A
See the examples in the Site editor > Styles panel
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Please confirm which theme type you used for testing.
The text was updated successfully, but these errors were encountered: