Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages data view: Clicking the featured image in grid layout no longer opens the editor #66588

Closed
jameskoster opened this issue Oct 30, 2024 · 5 comments · Fixed by #66365
Closed
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@jameskoster
Copy link
Contributor

On the Patterns and Templates data views, clicking the thumbnail in grid layout opens the editor. This used to be the case in the Pages data view too, but is no longer the case.

cc @oandregal @ntsekouras @youknowriad

@jameskoster jameskoster added [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Oct 30, 2024
@jameskoster
Copy link
Contributor Author

cc @gigitux in case this is related to #64496

@gigitux
Copy link
Contributor

gigitux commented Oct 30, 2024

We are aware of this! The behavior will be restored when #66365 is merged. Given that it is a regression, should we prioritize it?

@jameskoster
Copy link
Contributor Author

@gigitux I think it depends whether the bug is going to be in 6.7 or not as things stand. If it is, then we should probably prioritise :)

@gigitux
Copy link
Contributor

gigitux commented Oct 30, 2024

According to this page, the Gutenberg version included in Core is 19.3.

#64496 has been included in Gutenberg 19.6. Also, I checked WordPress Playground with WordPress 6.7-RC2 and the regression isn't reproducible.

@youknowriad
Copy link
Contributor

Yes, I think this should be given more priority. I do think the "onFocusItem" or "onClickItem" or something like that is the right solution for it. And we need to come up with the right heuristics:

  • Click media fields in grid triggers onClickItem is a good one.
  • Click primary fields in table should probably trigger onClickItem which also means we should remove the "clicking" behavior from the fields themselves.
  • Maybe there are other primary/media fields that should have this behavior in other layouts.

It's fine to start small though and only implement it for the current regression and iterate/expand separately. (Which is clicking media items in grid views)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants