Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image block should not have the "Add text over image" control when in Write mode #66875

Open
Tracked by #60021
richtabor opened this issue Nov 8, 2024 · 2 comments · May be fixed by #66880
Open
Tracked by #60021

Image block should not have the "Add text over image" control when in Write mode #66875

richtabor opened this issue Nov 8, 2024 · 2 comments · May be fixed by #66880
Assignees
@up1512001
Labels
[Block] Image Affects the Image Block [Feature] Write mode [Status] In Progress Tracking issues with work in progress

Comments

@richtabor
Copy link
Member

richtabor commented Nov 8, 2024 •
edited
Loading

Description

In the same vein as #66823, when the editor is in Write mode, the Image block should not display the "Add text over image" control in its toolbar. This control transforms the block into a cover block, which is likely to break the original layout intent as it shifts in size.

Visual

Image
@richtabor richtabor added the [Block] Image Affects the Image Block label Nov 8, 2024
@up1512001 up1512001 linked a pull request Nov 8, 2024 that will close this issue
Open
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 8, 2024
@annezazu annezazu mentioned this issue Nov 8, 2024
Open
23 tasks
@up1512001
Copy link
Member

@richtabor I have raised PR to address this, can you please review it. 🙇‍♂
#66880

@Mamaduka
Copy link
Member

There are also related conversations in #50025 and #56385.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@up1512001 up1512001

Labels
[Block] Image Affects the Image Block [Feature] Write mode [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Omit "design" controls from Image block toolbar while in write mode up1512001/gutenberg
4 participants
@Mamaduka @richtabor @ellatrix @up1512001