Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme preview: allow users to save changes before activating the theme #67631

Open
2 of 6 tasks
afercia opened this issue Dec 5, 2024 · 1 comment
Open
2 of 6 tasks
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Feature New feature to highlight in changelogs.

Comments

@afercia
Copy link
Contributor

afercia commented Dec 5, 2024

Description

@carolinan, @SergeyBiryukov and myself we're exploring potential improvements for theme creators and ways to make a theme customization flow more useful for some users.

The theme preview implemented in #50030 has great potential. From the WP admin > Appearance > any block theme > Live Preview, users can preview a non-active theme in the Site editor and they can also make changes to the previewd theme.

However, once they are done with their changes, they can only save and activate the theme.

For the future, we envision the Site Editor as a place where users can create a full theme from scratch. While there are many parts that should be implemented or improved to make the editor provide a full theme-creation experience, it seems to us that a good first step would be to decouple the 'Save' and 'Activate' actions in the Theme preview.

Allowing users to save their previewed theme changes before activating the theme would help other use cases as well. For example, users may want to deeply customize a previewed theme and that could require hours maybe days of work. By decoupling the Save and Activate actions, users would be able to take all the time they need for their customization work and activate when they are ready.

Code-wise, it looks like activation of the theme is always forced when saving changes to a previewed theme. It always assumes users want to activate the theme, while that may not be necessarily true.

Step-by-step reproduction instructions

  • Go to the WP admin > Appearance > any block theme > Live Preview.
  • Observe both the button in the Navigation panel and the one in the edit view top bar are labeled 'Activate {theme name}'.
  • Make changes to the previewed theme e.g. a simple color change in the global styles.
  • Observe both the button in the Navigation panel and the one in the edit view top bar are now labeled 'Activate {theme name} & Save'.
  • Observe there's no way to save your changes without also activating the theme.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@afercia afercia added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Feature New feature to highlight in changelogs. [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues labels Dec 5, 2024
@carolinan carolinan self-assigned this Dec 5, 2024
@annezazu annezazu removed the [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues label Dec 9, 2024
@annezazu
Copy link
Contributor

annezazu commented Dec 9, 2024

I imagine this will overlap with #29575 in terms of solutions!

@carolinan carolinan changed the title Theme preview: allow users to save changes before activating the them Theme preview: allow users to save changes before activating the theme Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Feature New feature to highlight in changelogs.
Projects
None yet
Development

No branches or pull requests

3 participants