Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacer block: height in pixels field label should be properly associated #6918

Closed
afercia opened this issue May 23, 2018 · 0 comments · Fixed by #6922
Closed

Spacer block: height in pixels field label should be properly associated #6918

afercia opened this issue May 23, 2018 · 0 comments · Fixed by #6922
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented May 23, 2018

The new "Spacer" block has a "height in pixels" field in the sidebar. This label should be properly associated with the field.

  • labels are not just for visual purposes
  • they give the control a name
  • when clicked, they focus the associated control
  • there's no need for an aria-label attribute if the <label> element is descriptive enough
@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels May 23, 2018
@afercia afercia self-assigned this May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant