Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block audit: Image #8291

Closed
6 of 11 tasks
sarahmonster opened this issue Jul 30, 2018 · 6 comments
Closed
6 of 11 tasks

Block audit: Image #8291

sarahmonster opened this issue Jul 30, 2018 · 6 comments
Assignees
Labels
[Block] Image Affects the Image Block [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@sarahmonster
Copy link
Member

sarahmonster commented Jul 30, 2018

Note: We'll be doing these audits in waves and editing this as we work through the blocks, so this text will be updated and fleshed out as we progress. See the full picture here.

Overview

screenshot 2018-07-30 13 32 06

Name: Image
Description: They’re worth 1,000 words! Insert a single image.
Category: Common blocks
CSS class: wp-block-image in editor and in frontend (on figure element)
Can be converted to: gallery, file

States

Empty:
screenshot 2018-07-30 13 54 06

Selected:

Before a caption:
screenshot 2018-07-30 13 54 58

With a caption:
screenshot 2018-07-30 13 58 53

Unselected:
screenshot 2018-07-30 13 58 26

Placeholder:
screenshot 2018-07-30 13 54 15

Primary (toolbar) settings

Align: left, centre, right, edit
Over caption: bold, italic, strikethrough, link

Secondary (sidebar) settings

Image Settings: Textual Alternative, Image Size, Image Dimensions
Link Settings: Link To, Link URL
Advanced: Additional CSS Class

Frontend appearance

Gutenberg starter theme:

Atomic Blocks

screen shot 2018-07-31 at 1 52 50 pm

twentyseventeen:

screen shot 2018-07-31 at 2 28 44 pm

twentyten:

screen shot 2018-07-31 at 2 27 20 pm

Bugs/errors

Individual issues will be opened for these soon

Suggestions

Individual issues will be opened for these soon

@sarahmonster sarahmonster self-assigned this Jul 30, 2018
@sarahmonster sarahmonster added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Blocks Overall functionality of blocks labels Jul 30, 2018
@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented Jul 31, 2018

Just in general, floated blocks are the most confusing and broken-feeling things in Gutenberg. There is a lot of stuff that needs to be fixed here.

Regarding sizing options, see #7636 and #7638. Resizing should be easier for keyboard users than it is now. The drag handles are not usable by keyboard users.

what's the difference between "image dimensions" and "image size"?

The Image Size is the source file, selected from one of the automatically-generated image files of various sizes that WordPress creates when you upload a file. It used to be called Source Type (or something like that). I think the current name of the option is confusing.

@postphotos
Copy link
Contributor

Hi @sarahmonster! I would strongly recommend a limited use of the word "caption" as it relates to media. I outlined why this is important in a Trac ticket here. It mostly has to do with consistency in how we approach all content with subtitles.

An alternate option that could work would be Write a description.... Let me know if this needs a new issue ticket!

@bph
Copy link
Contributor

bph commented Aug 18, 2018

We noticed a few support tickets where people would like to set a title for the image they uploaded via the image block. The sidebar doesn't have all the fields, they see in the current editor. The work around is right now, to save the draft, get out of the editing process, go to the media library look for the newly uploaded image and fill in the title. But even if that is done, the front end doesn't display the image title. It's an SEO relevant attribute for an image, if ranking their image in search result pages is important to the site owner

@rosswintle
Copy link
Contributor

+1 for @bph's title issue. Auto-generated media titles are derived from the file name, and no-one wants a media library full of things called "IMG0756" or "Screenshot 2018-09-04 10:20:30" because you can't then find anything in the media library.

I have to work really hard to get my clients to add titles so that when they search for images they can find media that they've added in the past easily.

I'd really like Gutenberg to put some emphasis on giving images titles as well as captions and alt-texts. The classic editor at least made this possible.

Please make editing the title possible, as a minimum, and emphasise it if you can.

Thanks

@sarahmonster
Copy link
Member Author

@postphotos I totally see your argument here, and I'm of two minds. I love consistency, but we also use "description" elsewhere, and a caption isn't necessarily the same as a description. The ALT text for the image should definitely be a description, but the caption tends to be more editorial, and I'd be concerned that using description as a prompt here might encourage misuse of these inputs.

It sounds like something you've put a lot of thought into, so it might be worth opening an issue to have a bit more discussion! :)

@sarahmonster
Copy link
Member Author

@bph @rosswintle I've filed #11054 for the title issue.

All issues here have been filed as individual issues, so I'm going to go ahead and close out this tracking bug. Feel free to comment on if I missed anything, or open new issues as needed! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

5 participants