Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block audit: Classic #8368

Closed
1 of 6 tasks
kjellr opened this issue Aug 1, 2018 · 1 comment
Closed
1 of 6 tasks

Block audit: Classic #8368

kjellr opened this issue Aug 1, 2018 · 1 comment
Assignees
Labels
[Block] Classic Affects the Classic Editor Block [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@kjellr
Copy link
Contributor

kjellr commented Aug 1, 2018

Note: We'll be doing these audits in waves and editing this as we work through the blocks, so this text will be updated and fleshed out as we progress. See the full picture here.

Overview

screen shot 2018-08-01 at 1 41 10 pm

Name: Classic
Description: It’s the classic WordPress editor and it’s a block! Drop the editor right in.
Category: Formatting
CSS class: .editor-block-list__block class in editor, nothing in frontend.
Can be converted to: Content within the Classic block can be "Converted to Blocks".

States

Empty:

screen shot 2018-08-01 at 12 43 55 pm

Selected:

screen shot 2018-08-01 at 12 46 55 pm

Unselected:

screen shot 2018-08-01 at 12 46 55 pm

Placeholder:

screen shot 2018-08-01 at 12 43 55 pm

(that's not a mistake — they're all the same)

Primary (toolbar) settings

None

Secondary (sidebar) settings

None

Frontend appearance

(I'm omitting front end screenshots: Since this block outputs its content directly into entry-content — with no wrapper element — it defaults to the theme's standard styles entirely.)

Bugs/errors

Individual issues will be opened for these soon

Suggestions

Individual issues will be opened for these soon

  • Is the "Classic" name clear enough? I might suggest calling it the "Classic Editor" or something similar.
  • It's a little weird that the black has only one state. Should it have a hover/selected state like the other blocks do? It looks like this was considered at one point, but must've been removed later on.
  • I fully expected to be able to drag/drop images into the Classic block. I wasn't able to. (Can't insert Inline Image into Classic Block #7762). This is especially confusing because Classic blocks that are auto-created from the Classic editor can have images in them. But it's impossible to add an image to a Classic block that a user has inserted via Gutenberg.
  • It's confusing that this block includes block-level undo/redo options, and that they don't behave the same way as the global undo/redo buttons do. (Classic Block: Block contains its own undo/redo buttons.  #8729)
@danielbachhuber danielbachhuber added the [Feature] Blocks Overall functionality of blocks label Aug 1, 2018
@kjellr kjellr added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Aug 1, 2018
@kjellr kjellr self-assigned this Aug 2, 2018
@ellatrix ellatrix added the [Block] Classic Affects the Classic Editor Block label Oct 31, 2018
@kjellr
Copy link
Contributor Author

kjellr commented Jan 18, 2019

All the issues raised here have been opened as individual issues now (except for the naming + single state observations, which I consider more ponderings than actual issues). Going to close this for now, and we can continue discussion in the individual issues instead. 👍

@kjellr kjellr closed this as completed Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Classic Affects the Classic Editor Block [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

3 participants