withFilters: Filter is not applied

[mmtr]

Describe the bug
When rendering a component using the withFilters higher order component outside Gutenberg, the filter is not applied.

To Reproduce
Execute the code below in a new React project after installing @wordpress/components and @wordpress/hooks.

import { withFilters } from '@wordpress/components';
import { addFilter } from '@wordpress/hooks';

const ComposedComponent = () => <div>Composed component</div>;

addFilter(
	'MyHookName',
	'example/filtered-component',
	( FilteredComponent ) => () => (
		<div>
			<FilteredComponent />
			<ComposedComponent />
		</div>
	)
);

const MyComponentWithFilters = withFilters( 'MyHookName' )( 
	() => <div>My component</div> 
);

ReactDOM.render(
	<MyComponentWithFilters />,
	document.getElementById( 'root' )
);

Expected behavior
"Composed component" should appear below "My component".

Screenshots

Desktop:

• OS: macOS High Sierra
• Browser: Chrome
• Version: 67

Additional context
Issue found while working on #8338 and Automattic/wp-calypso#26367

[gziolo]

I can't reproduce inside Gutenberg:

Can you try again outside of LiveReact context and confirm?

[mmtr]

you're right! react-live is causing the issue. I have tested it in a clean project and is working nicely:

• Demo: https://mmtr.github.io/wordpress-components/#/with-filters
• Code: https://github.com/mmtr/wordpress-components/blob/master/src/examples/with-filters.jsx

I'll try to figure out how to solve the issue with react-live.

sorry for false alarm!

[mmtr]

It looks like the issue is present with @wordpress/components@2.0.0:

• Demo: https://mmtr.github.io/wordpress-components/#/with-filters
• Code: https://github.com/mmtr/wordpress-components/blob/master/src/examples/with-filters.jsx

[gziolo]

Don’t you encounter a similar issue as with data package where 2 instances of the same library with different versions are loaded?

[mmtr]

I think you're confusing with someone else. I have not played around yet with the data package.

[gziolo]

It was a question, see a related discussion where two different versions of the same library were loaded causing issues with internal state: Automattic/wp-calypso#26438 (comment)

@jsnajdr can you help to debug this one?

[jsnajdr]

Yes, it looks like the @wordpress/hooks module is duplicated and because it contains a filter registry, the addFilter and applyFilters function work with different registries.

On my local wp-calypso, I have 5 copies:

$ find . -path "*/@wordpress/hooks"
./node_modules/@wordpress/blocks/node_modules/@wordpress/hooks
./node_modules/@wordpress/api-fetch/node_modules/@wordpress/hooks
./node_modules/@wordpress/components/node_modules/@wordpress/hooks
./node_modules/@wordpress/hooks
./node_modules/@wordpress/editor/node_modules/@wordpress/hooks

The solution is to regenerate the npm-shrinkwrap.json file with npm run update-deps. That forces NPM to deduplicate the modules. It's also important that @wordpress/hooks is a top level dependency of Calypso, but it already is.

[gziolo]

@jsnajdr, thanks for double checking this one. I'm closing this issue in here, because it isn't an issue with hooks itself. We will try to come up with an action item to attack this general issue of consuming multiple @wordpress/* packages at once tomorrow during Core JS meeting.
See: https://docs.google.com/document/d/1KNa4xxktVskFV86SVMbdTWx3bINrLikBnJpntBZw1DU/edit.