Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Allow custom CSS classes on a block #887

Closed
jasmussen opened this issue May 24, 2017 · 5 comments
Closed

Blocks: Allow custom CSS classes on a block #887

jasmussen opened this issue May 24, 2017 · 5 comments
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Document Settings Document settings experience [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@jasmussen
Copy link
Contributor

Idea by Jesse Friedman: Auto-ID every block and let you customize both this ID, and a custom CSS class in the block settings.

These fields could be surfaced in the Inspector. See also #672

@jasmussen jasmussen added [Feature] Blocks Overall functionality of blocks [Feature] Document Settings Document settings experience [Type] Enhancement A suggestion for improvement. labels May 24, 2017
@youknowriad
Copy link
Contributor

FWIW, we already have a uid by block. We'll have to persist it though

@jasmussen jasmussen added this to the Beta 0.8.0 milestone Jul 5, 2017
@jasmussen jasmussen changed the title Blocks: Auto-ID blocks, and allow custom classes Blocks: Allow custom CSS classes on a block Jul 5, 2017
@mtias mtias modified the milestones: Beta 0.6.0, Beta 0.8.0 Jul 6, 2017
@mtias
Copy link
Member

mtias commented Jul 14, 2017

Done in #1889.

@mtias mtias closed this as completed Jul 14, 2017
@StaggerLeee
Copy link

Tell me please you will not ship this in the core ?
Why are you forcing something you know in advance at least 90% od WordPress users dont know what it is, and could not care less.

@jasmussen
Copy link
Contributor Author

@StaggerLeee As a meta note, Gutenberg will not reach core without changes. What we are working towards right now is a "vision complete" state. After that comes a long polish phase, and at some point the project will be presented as our suggestion for the next WordPress editor. I expect many changes to happen once we present it as such. I.e. features may be added or removed. And so some of these features we are building to test them out.

I'd also note that the additional CSS class is optional, and it lives in the sidebar inspector. So if you dismiss the sidebar, you'll never see it. See also https://github.com/WordPress/gutenberg/blob/master/docs/design.md#advanced-settings

@StaggerLeee
Copy link

OK, thank you for explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Document Settings Document settings experience [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants