Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct plural for "children" #915

Closed
franz-josef-kaiser opened this issue May 26, 2017 · 3 comments · Fixed by #1232
Closed

Use correct plural for "children" #915

franz-josef-kaiser opened this issue May 26, 2017 · 3 comments · Fixed by #1232
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time

Comments

@franz-josef-kaiser
Copy link

Yes, but no, there is no s in the plural form form of children :)
@nylen nylen added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label May 26, 2017
@aduth
Copy link
Member

aduth commented May 26, 2017

Alternative suggestion for "array of children" ?

@nylen
Copy link
Member

nylen commented May 26, 2017

Chitlins.

@nylen
Copy link
Member

nylen commented May 27, 2017 •
edited
Loading

For a more practical suggestion, childrenArguments and an updated doc comment like "Array of children arguments (array of arrays/strings/objects) to concatenate".

@maurobringolf maurobringolf mentioned this issue Jun 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename concatChildren() argument from childrens to childrenArguments maurobringolf/gutenberg
3 participants
@nylen @franz-josef-kaiser @aduth