Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18N: Use letters for formatting buttons instead of SVG #9313

Closed
webaxones opened this issue Aug 24, 2018 · 5 comments
Closed

i18N: Use letters for formatting buttons instead of SVG #9313

webaxones opened this issue Aug 24, 2018 · 5 comments
Labels
[Block] Heading Affects the Headings Block Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.

Comments

@webaxones
Copy link

webaxones commented Aug 24, 2018

Hi,

A typical user does not necessarily know what are h1, h2, h3. It would be nice and easy to take advantage of an evolution like Gutenberg to make an interface improvement by not reproducing this HMI error and replacing the SVG icons with real letters that would make them translatable.
Example for French:
H1, H2, H3 > T1, T2, T3
B> G
I> I
Before :
now
After :
then

@youknowriad youknowriad added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. labels Aug 24, 2018
@youknowriad
Copy link
Contributor

youknowriad commented Aug 24, 2018

I think one issue with that is that it creates an inconsistency with the classic block where it's a TinyMCE toolbar not controlled by Gutenberg itself. I'm no designer though, other opinions would be good.

@youknowriad youknowriad changed the title Simple HMI evolution i18N: Use letters for formatting buttons instead of SVG Aug 24, 2018
@youknowriad youknowriad added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Aug 24, 2018
@jasmussen
Copy link
Contributor

We now have a way to collapse panel groups into dropdowns. When we do that we can show more than 3 options for heading levels in the dropdown, and remove that from the sidebar. Additionally this will allow us to show the full "Heading 1" labels in that dropdown, which should fix this issue.

CC: @gziolo because you had thoughts on this.

@jasmussen jasmussen removed the Needs Design Feedback Needs general design feedback. label Oct 11, 2018
@gziolo
Copy link
Member

gziolo commented Oct 15, 2018

Yeah, I second what @jasmussen said. I don't have time to look into it this week, but this seems like a good compromise. To have an icon and show full text when dropdown shows up.

@tomdevisser
Copy link
Member

@gziolo @jasmussen What's the status of this issue? Has the compromise been implemented and can the issue be closed, and if not, what else has to be done?

@jasmussen
Copy link
Contributor

Here's what the dropdown looks like today:

Screenshot 2023-03-13 at 10 57 26

Because so much has changed, I'll tentatively close this one. Let me know if this was in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Heading Affects the Headings Block Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants