Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift + Arrow keys (and combinations) should work even with block boundaries faded out #958

Closed
jasmussen opened this issue May 31, 2017 · 6 comments
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Milestone

Comments

@jasmussen
Copy link
Contributor

Steps to reproduce:

  • Set focus in a text block. Start typing. Note the block boundaries fade out.
  • Hold shift, press left arrow to select in that direction.

Expected result: block boundaries fade in and you select one character leftwards.

Actual result: block boundaries fade in.

may-31-2017 15-26-41

It's a bit hard to see in that GIF. Sometimes you do select one character leftwards but that selection is immediately unset.

@jasmussen jasmussen added [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended labels May 31, 2017
@ellatrix
Copy link
Member

ellatrix commented Jun 1, 2017

Maybe I'm not understanding it correctly, but you wanted the boundaries to show when text is selected right?

@jasmussen
Copy link
Contributor Author

Maybe I'm not understanding it correctly, but you wanted the boundaries to show when text is selected right?

Yes absolutely! That part is working.

The problem is that as I'm writing text, using just the keyboard, every once in a while I'll want to delete a few characters, and I'll hold shift, press left, and delete. Only here, I have to press left twice to select a single character.

Try the following in a normal text editor, then in the gutenberg editor, to see the difference:

  1. type a little
  2. hold shift, press left

In the normal text editor, the above will select one character. In gutenberg, currently, it doesn't select anything. You have to press left twice.

@spocke
Copy link

spocke commented Jun 13, 2017

Right it should just skip the invisible character we have there on shift currently we don't override shift/ctrl combinations of selection. This whole feature is all about overriding everything a browser does natively when it comes to selections so I guess there is more cases to handle.

@jasmussen
Copy link
Contributor Author

Just to clarify, I didn't want to suggest this was an issue with the inline boundaries specifically, but rather with the basic text block as a whole in gutenberg. I don't think it's a tinymce issue, actually.

@ellatrix
Copy link
Member

@jasmussen Is this still an issue? I can't reproduce in master.

@jasmussen
Copy link
Contributor Author

You're right, this seems addressed! Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants