-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Block: More #983
Comments
Note that this comment can currently be anywhere in the content, not necessarily at the top level. Not that this needs to be possible with the block editor, just making this note for old content. |
Very slick. Love it, thank you @jwold. If we are able to add some recency to the inserter ( #888 ), which seems increasingly important as 30+ blocks are incoming with the embed aliases, the category becomes slightly less important. However it feels like a layout block to me, as it affects the front-end layout rendering. What do you think? |
Thanks @jasmussen! I wanted to followup on your question above:
|
Very soon, "embed aliases" will be merged into master, which means if you check out and build the plugin (or wait another week and get it from the plugin repo, fingers crossed), you'll see a whole bunch of blocks. Every oembed supported in WordPress gets its own block. Even if it's a thin veneer.
Yep, this is the type of enhancement stuff that makes sense to think about. The idea I had initially was to mimic the emoji inserter pattern, with tabs. The idea being that it's important that search can find the block you need. |
I think I'll have to just wait. Looking forward to it! My background is more frontend. By chance is there a screenshot that could be shared?
I like that idea. Did you end up wireframing it? Would love to play a bit with it. |
The embeds alias pull request was merged earlier today, and can be seen on this demo site: https://testgutenberg.wpkonsulterna.se/wp-admin/admin.php?page=gutenberg |
You might need to click the login link in the homepage: https://testgutenberg.wpkonsulterna.se/
There's a screenshot in this ticket which we closed. But the concept can be revisited: #81 |
@jasmussen and @aduth thanks! That link was helpful. Here is a prototype I've been playing with (hotspots should appear when you click around): https://invis.io/DMC2YHNG5#/238003019_Recent
|
I dig that quite a lot, @jwold. I'm on board with that. Though it'd be nice if we could start with only a few tabs so that we don't require any overflow magic yet. Then one day when it becomes pressing with more tabs, we can look into an overflow mechanism for the tabs. |
@jasmussen good point! Let's keep it simpler. I've made some changes to how blocks are labeled, shortening some of the labels and combining two of them. This allows us to fit all of them into the tab interface at the bottom without an overflow section, and without being required to only use icons. Any suggestions/feedback? (note that all the buttons at the bottom are clickable, including search) Link: https://xd.adobe.com/view/709eff9d-2c54-495b-8c42-fb01f9585385/ |
Sorry for the belated response, been to Paris for a meetup, it's been intense. Prototype and design is solid! Thanks for doing that @jwold! It seems as if the tabs at the bottom function as "bookmarks" for scroll anchors now, essentially duplicating the categories. Would it make sense to approach it as separate things? I.e. we have, say, 3 tabs at the bottom:
Yes, we might want to make the inserter a bit wider to accommodate these. Each tab is its own screen, showing only blocks in that are in said tab. Under each tab, we can then have sub-headings. For example, Text & Media might have these subheadings:
We might even want to start with just two tabs, "Blocks" and "Embeds", and then expand when we see a need to? |
@jasmussen no worries, it’s always a bit crazy around WordCamp time!
|
Solid thoughts, solid prototype. I think that's basically what we should use as the target mockup for now.
It has to be able to do both. When you click the inserter from the Editor Bar at the top, it has to open downwards, and if you clik the inserter from the one at the bottom of the block list it opens upwards (unless you're at the start of the document). In both cases, the search box needs to be close to the inserter button, so that we can set focus there in an accessible way. Here's what I'd imagine, very quick and dirty: I phrased the headings/subheadings badly. I meant only one level, so I should've said headings. What I meant to say was that since we're using a gray material for the tabs, we should probably remove the gray material from the headings. Something like this: |
Thanks for the feedback!
(Will post the new prototype shortly) |
@jasmussen I believe the prototype is up to date. Let me know if you recommend any further changes. https://xd.adobe.com/view/57a1eb10-949b-48fe-bc4e-48a2bb587d66/ I like the simplicity of the headers dividing the sections without background colors. Might play with it some more in the future, but for now it's good. |
Love it. I think it's solid. Thanks so much! |
Should we open a separate ticket, with your prototype as the mockup? |
I think there's a massive amount of cognitive load to scan the amount of embeds as they currently exist, particularly when considering that each embed requires the same input once you've selected it (a URL). I understand the "mystery meat" embed approach, but I think a simplified approach would go a long way to fulfilling the "effortless" portion of editor focus:
I think this is a pattern that is reflected in other services (Facebook comes immediately to mind when pasting links into updates). This approach would alleviate dependency on search as well, or perhaps, change search so that when searching "Vine," the embed block would show. |
This issue here should be used to talk about a "More" block, so yeah I'd definitely open a new issue for this unrelated topic. |
Maybe make it full-width, since we can, that'd be nice. |
Yes, I'm familiar with the current one, but it sounds like a good chance to improve on it (it's also an image in core as far as I remember). |
So long as it's an abstract concept implying the stuff above this separator will show on archives and indexes, what's below shows on the single page, I don't know that there's a ton we can do. Except full width, as it hit me above. But good point, I'll open the discussion to core editor also 🎉 |
Please note that users currently can add custom text to the more tag. This needs to be supported. |
I think full width would be nice like you said. But I don't think that "the stuff above this separator will show on archives and indexes, what's below shows on the single page" every really comes across even in its current implementation. Not quite sure what to do about that other to maybe instead of a cog on the block have an info icon that explains what it is. |
Assigning to you @dmsnell, because you seem to be currently developing. |
Maybe when you click into it, Read More could turn into a placeholder, like the citation in the quote block. |
Well the parser now supports this but I haven't added the block. Can maybe try next Monday if I don't have higher-priority tasks on Gutenberg then! In the meantime, this is a good first-commit kind of block |
Note that only one of these blocks should be allowed for a given post. As such, it depends on #1661 to prevent multiple more blocks from being added at a time. |
#1661 has been merged, we could use the |
closed by #1440 |
We need to implement a more-tag block, the one that gives the ability of splitting a post with a "read more..." link.
This already exists as a comment in WordPress, it'd be good to adapt our parsing to recognize it without extra comments. We also need a good visual design for it.
The text was updated successfully, but these errors were encountered: