Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Try to move filtering blocks until editor mounts #10554

Closed
wants to merge 2 commits into from

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Oct 12, 2018

Description

Resolves: #4848.

WIP

In the ideal case we should be able to support the following:

  • register block override
  • register block
  • register block override
  • initialize editor and let users write their post
  • register block (and apply all previously registered overrides)
  • unregister block
  • register block override and apply to all matching blocks
  • remove override and update matching blocks

How has this been tested?

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo added [Type] Bug An existing feature does not function as intended [Feature] Block API API that allows to express the block paradigm. [Status] In Progress Tracking issues with work in progress labels Oct 12, 2018
@gziolo gziolo requested review from aduth and youknowriad October 12, 2018 13:15
@gziolo gziolo requested review from gwwar and vindl October 22, 2018 16:00
@gziolo gziolo self-assigned this Nov 29, 2018
@gziolo gziolo added [Type] Technical Prototype Offers a technical exploration into an idea as an example of what's possible and removed [Status] In Progress Tracking issues with work in progress labels Feb 8, 2019
@gziolo
Copy link
Member Author

gziolo commented Feb 8, 2019

I don't plan to work further on this one since we are going to change the way how blocks can be registered after we agree on #13693. Depending on the final shape of blocks registration the solution proposed here might be completely different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Type] Bug An existing feature does not function as intended [Type] Technical Prototype Offers a technical exploration into an idea as an example of what's possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

From v2.1.0 wp.blocks.getBlockTypes() returns an empty Array
1 participant