RichText: Ensure multiline prop is either "p" or "li" #10664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Feature] Rich Text
gziolo
approved these changes
Oct 17, 2018
There was a problem hiding this comment.
I tested it with the following blocks:
- List
- Quote
- Pullquote
Everything works perfectly fine. Code looks good, too. In the long run, we probably should leave multiline boolean and add some separate prop dedicated to lists. Unless we convert List block to work as a nested block and solve the issue this way :)
mcsf
pushed a commit
that referenced
this pull request
Nov 1, 2018
* Ensure multiline prop is either p or li * Make booleans work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses: #10323 (comment) by @mcsf.
This change would ensure that the
multilineprop onRichTextis eitherporliso block authors do not pass anything strange here. If they don't pass anything it will be set top. The documentation suggests thatpshould be passed, I would change that to suggest just passingmultilinefor paragraphs. List is a bit of a special case here which we don't really want to put in the documentation, and may be deprecated in the future.How has this been tested?
Ensure multiline instances work correctly. Test should catch any problems.
Screenshots
Types of changes
Checklist: