Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checks for store existance in withSelect HOCs for media components #11903

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Remove checks for store existance in withSelect HOCs for media components #11903

merged 1 commit into from
Nov 15, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Nov 15, 2018

Description

This is follow-up for work done by @imath in #4155. It addresses comments left by @youknowriad:

How has this been tested?

npm test

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo added the [Type] Code Quality Issues or PRs that relate to code quality label Nov 15, 2018
@gziolo gziolo added this to the 4.5 milestone Nov 15, 2018
@gziolo gziolo self-assigned this Nov 15, 2018
@gziolo gziolo requested a review from youknowriad November 15, 2018 10:55
@gziolo gziolo force-pushed the update/tweaks-media-upload-check branch from 3569a54 to 60f90f1 Compare November 15, 2018 10:57
youknowriad
youknowriad approved these changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gziolo gziolo modified the milestones: 4.5, 4.4 Nov 15, 2018
@gziolo gziolo merged commit 5f44a42 into master Nov 15, 2018
@gziolo gziolo deleted the update/tweaks-media-upload-check branch November 15, 2018 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

Assignees

@gziolo gziolo

Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@gziolo @youknowriad