-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unreliable link test #13161
Fix unreliable link test #13161
Conversation
80f411f
to
29825aa
Compare
Hey @gziolo - I haven't really done any more to fix this one beyond a few changes to the test code. I wasn't able to work out why it was failing. However, over the last 1-2 weeks I've been running the tests on travis in this branch on a daily basis, and I haven't seen a single failure of the test in question. I wonder if other code changes have resulted in this test becoming more stable 🤔 I think it might be worth trying to reintroduce the test— we can always disable it again if we see some failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's reintroduce this test then :)
This is still failing in several PRs for me. Let's disable all the unstable tests we find. |
@@ -267,7 +267,7 @@ describe( 'Links', () => { | |||
|
|||
// Test for regressions of https://github.com/WordPress/gutenberg/issues/10496. | |||
// Disabled until improved as it wasn't reliable enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment should have been removed.
See #15059 |
Attempts to fix #13044. This failure only happens in CI (unable to reproduce locally) hence this PR
Description
How has this been tested?
Screenshots
Types of changes
Checklist: