-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HorizontalRule component for cross-platform separator block #14361
Conversation
830e289
to
7336885
Compare
@gziolo thanks for the suggestions. I'll do some more testing next week and get this ready to review and merge |
I think this is ready to review. I tested on mobile and web and everything looks ok. I considered adding a README.md to the new primitive, but I couldn't come up with anything good, since it's mostly a wrapper for |
I think this is totally expected to be that simple :) It will be exposed in the sidebar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add docs and get it merged 👍
Added a README and entry on the CHANGELOG, let me know if that looks good 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I proposed expanded description based on MDN docs :)
Thanks for working on it 👍
@@ -1127,6 +1127,12 @@ | |||
"markdown_source": "https://raw.githubusercontent.com/WordPress/gutenberg/master/packages/components/src/popover/README.md", | |||
"parent": "components" | |||
}, | |||
{ | |||
"title": "HorizontalRule", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automation works :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of 😁
I think this was generated by the precommit hook, but not included in the commit that added the README. I only noticed it because I did a second commit with the Usage section
Co-Authored-By: koke <jbernal@gmail.com>
Description
This PR adds a
HorizontalRule
wrapper to thehr
HTML tag, using react-native-hr on the native implementation, to allow for a cross platform separator block.How has this been tested?
Tested on mobile:
Tested on web:
Screenshots
Types of changes
Checklist: