-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile]Improve accessibility on Heading block #15144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested via wordpress-mobile/gutenberg-mobile#925 (review)
Great job!
Opened #15161 for this. |
Thanks for the heads-up @swissspidy These are the strings to be read out loudly by screen readers(as a part of device accessibility), we just wanted to put a pause between the words and it is done by dot+space. So we didn't want to derive new strings just to put '. ' after them. BTW I totally agree that 'level' should be fixed as 'level %s', that's sth we missed. So, if deriving new strings is the more preferred way by translators that's perfectly ok for us, and it is easier for us to code too! |
Thanks for the additional context. Yes, I would say in this case new strings is better. String concatenation does not work for every language there is, and a complete sentence is much easier to comprehend for translators. |
Description
This PR improves accessibility on Heading block.
Fixes wordpress-mobile/gutenberg-mobile#908
To test:
Please refer to the gutenberg-mobile side PR.
Checklist: