Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Image Block: Update media link when image is replaced #17226

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Fix: Image Block: Update media link when image is replaced #17226

merged 1 commit into from
Nov 19, 2019

Conversation

donmhico
Copy link
Contributor

Description

Update the Media Link in the image block when the image is replaced.

How has this been tested?

  1. Confirmed the bug by following the steps provided in Image Block maintains link to previous media after replacing an image #17119.
  2. Applied the changes / additions.
  3. No longer able to reproduce the bug.

Types of changes

Fixes #17119.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.

@talldan talldan added [Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended labels Aug 29, 2019
draganescu
draganescu approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this and it worked in fixing the link destination bug. The code is a simple update of the function used to set the a new image in the block onSelectImage and handles updating previously set props.

@draganescu draganescu merged commit 834a99b into WordPress:master Nov 19, 2019
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draganescu draganescu draganescu approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 7.0
Development

Successfully merging this pull request may close these issues.

Image Block maintains link to previous media after replacing an image
4 participants
@donmhico @draganescu @youknowriad @talldan