Social Links: Change default state to WordPress link instead of mail #17402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaz
added
the
[Block] Social
jasmussen
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per discussion in #17362 switch default link to WordPress instead of mail.
If unchanged, this will insert a valid link, whereas the mail link unchanged when be an invalid link.
The purpose of including a link prefilled is so the block does not "disappear" when unselected.
How has this been tested?
Confirm WordPress icon shows and is properly linked to https://wordpress.org/
Types of changes
Switches template for default state of the social-links/edit.js function.
Checklist: