Update E2E tests for Twenty Twenty theme #17566
Conversation
…ont size input' test for Twenty Twenty
…st title and content in the preview' test for Twenty Twenty
noisysocks
requested review from
ajitbohra,
gziolo,
nerrad,
ntwb and
talldan
as code owners
noisysocks
added
the
[Type] Automated Testing
| @@ -16,7 +16,7 @@ describe( 'Managing reusable blocks', () => { | |||
| * @return {Promise} Promise resolving to number of post list entries. | |||
| */ | |||
| async function getNumberOfEntries() { | |||
| return page.evaluate( () => document.querySelectorAll( '.entry' ).length ); | |||
| return page.evaluate( () => document.querySelectorAll( '.hentry' ).length ); | |||
There was a problem hiding this comment.
Yeah I'm not really sure how this ever worked. The rows in the Manage All Blocks screen have class hentry. We could maybe consider selecting .type-wp_block instead.
|
Congrats for making Travis happy again 💯 |
|
What typewriter tests were failing? |
These two:
Both failures were to do with the default font size changing. This meant that there wasn't a scrollable container on the page. Would appreciate you double checking the changes in this PR to make sure I didn't bugger it up 🙂 |
|
@noisysocks I'm not sure if they have to do with the font size change. Some of the tests are now changed and don't test the correct thing anymore. E.g. the scroll test should happen at the very start, not after the page has already been scrolled. Something is going wrong because in the e2e test there is no scroll container. |
|
The container has now a much smaller width, so because of the styles it's not scrollable. |
|
I'm not sure why that whitespace is there... |
|
Thanks for checking! Looks like I did indeed bugger it up 🙂 That margin is very strange. Does it appear when you run Gutenberg normally? Is it something to do with the WP Admin menu being collapsed? |
* Update 'Heading › it should correctly apply named colors' test for Twenty Twenty * Update 'TypeWriter' tests for Twenty Twenty * Update 'Font Size Picker › should apply a named font size using the font size input' test for Twenty Twenty * Update 'Preview with Custom Fields enabled › displays edits to the post title and content in the preview' test for Twenty Twenty * Fix 'Managing reusable blocks › Should import reusable blocks' test * TypeWriter E2E tests: Use <= instead of <
* Update 'Heading › it should correctly apply named colors' test for Twenty Twenty * Update 'TypeWriter' tests for Twenty Twenty * Update 'Font Size Picker › should apply a named font size using the font size input' test for Twenty Twenty * Update 'Preview with Custom Fields enabled › displays edits to the post title and content in the preview' test for Twenty Twenty * Fix 'Managing reusable blocks › Should import reusable blocks' test * TypeWriter E2E tests: Use <= instead of <
Update the E2E tests to work with the new Twenty Twenty theme in trunk.