Fix helper top margin when used with RadioControl. #17677
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
help
prop is used withRadioControl
component to show the helper text for the settings field in the sidebar, the helper text looks very stitched up with the radio buttons above.Ref: https://wordpress.slack.com/archives/C02QB2JS7/p1569910120382900
How has this been tested?
This PR fixes that issue by removing (overriding) the negative top margin applied to
components-base-control__help
class fromBaseControl
component, so that it gets some breathing space. Decided to override the styles inRadioControl
so that other components stay unaffected.Screenshots
Before
After
Types of changes
Checklist: