Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle control component to Storybook #18388

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Conversation

brentswisher
Copy link
Contributor

Description

Adds the ToggleControl component to Storybook as part of #17973.

I added two stories, one with just the toggle control and one with variable help text based on the checked status.

How has this been tested?

run npm run design-system:dev
Browse to the local Storybook instance
See toggle control is rendered when selected in the left-hand navigation

Types of changes

New feature (non-breaking change which adds functionality)

@gziolo gziolo added [Feature] UI Components Impacts or related to the UI component system Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code Storybook Storybook and its stories for components labels Nov 8, 2019
Copy link
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works in storybook.

@brentswisher brentswisher force-pushed the add/toggle-control-storybook branch from 1da7769 to 3162504 Compare November 8, 2019 14:04
@Soean Soean merged commit 37301b8 into master Nov 8, 2019
@Soean Soean deleted the add/toggle-control-storybook branch November 8, 2019 14:42
@youknowriad youknowriad added this to the Gutenberg 6.9 milestone Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code Storybook Storybook and its stories for components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants