Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Add TabPanel #18402

Merged
merged 2 commits into from
Nov 12, 2019
Merged

Storybook: Add TabPanel #18402

merged 2 commits into from
Nov 12, 2019

Conversation

Soean
Copy link
Member

@Soean Soean commented Nov 8, 2019

Description

This PR adds a story for the TabPanel component as part of #17973.

How has this been tested?

run npm run design-system:dev
Browse to the local Storybook instance
See TabPanel is rendered when selected in the left-hand navigation

@Soean Soean added [Feature] UI Components Impacts or related to the UI component system Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code Storybook Storybook and its stories for components labels Nov 8, 2019
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Soean Soean merged commit 9a517c1 into master Nov 12, 2019
@Soean Soean deleted the storybook/add-tab-panel branch November 12, 2019 20:12
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code Storybook Storybook and its stories for components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants