Fix responsive video embed previews. #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Niice! Thanks for doing this, sorry I missed the PR. I pushed some polish to the code, so embeds have slightly less margin now, and videos are responsive also in aspect ratio:
By the way can we easily add the generic "Embed" block to the "Recents" tab also? I know it shows up as soon as you use it the first time. But it'd be nice to pre-populate it there. I think this is good to ship! Nice work! |
Sets the height of video embeds dynamically. Tested with the following: * Short tweet: https://twitter.com/notnownikki/status/876229494465581056 * Tall tweet: https://twitter.com/PattyJenks/status/874034832430424065 * Youtube: https://www.youtube.com/watch?v=PfKUdmTq2MI * Photo: https://cloudup.com/cl3Oq5MU8Rm * Long tumblr post: http://doctorwho.tumblr.com/post/162052108791 * Custom HTML block
notnownikki
force-pushed
the
fix/responsive-video-embeds
branch
from
7178f46 to
69982c7
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the height of video embeds dynamically.
Tested with the following: