From 2fe24e0308fe3e0abe1539fde429a8a98bdd3efd Mon Sep 17 00:00:00 2001 From: Andrew Duthie Date: Thu, 23 Jan 2020 09:49:58 -0500 Subject: [PATCH] Testing: Use deterministic selectors for incremented IDs --- packages/e2e-tests/config/setup-test-framework.js | 4 ++-- packages/e2e-tests/specs/editor/various/embedding.test.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/e2e-tests/config/setup-test-framework.js b/packages/e2e-tests/config/setup-test-framework.js index ee4bbf1ea41881..edc2c521ee7bec 100644 --- a/packages/e2e-tests/config/setup-test-framework.js +++ b/packages/e2e-tests/config/setup-test-framework.js @@ -83,8 +83,8 @@ async function trashExistingPosts() { } // Select all posts. - await page.waitForSelector( '#cb-select-all-1' ); - await page.click( '#cb-select-all-1' ); + await page.waitForSelector( '[id^=cb-select-all-]' ); + await page.click( '[id^=cb-select-all-]' ); // Select the "bulk actions" > "trash" option. await page.select( '#bulk-action-selector-top', 'trash' ); // Submit the form to send all draft/scheduled/published posts to the trash. diff --git a/packages/e2e-tests/specs/editor/various/embedding.test.js b/packages/e2e-tests/specs/editor/various/embedding.test.js index 53dec261440586..d753a89863e787 100644 --- a/packages/e2e-tests/specs/editor/various/embedding.test.js +++ b/packages/e2e-tests/specs/editor/various/embedding.test.js @@ -251,7 +251,7 @@ describe( 'Embedding content', () => { await insertBlock( 'Paragraph' ); await page.keyboard.type( 'Hello there!' ); await publishPost(); - const postUrl = await page.$eval( '#inspector-text-control-0', ( el ) => el.value ); + const postUrl = await page.$eval( '[id^=inspector-text-control-]', ( el ) => el.value ); // Start a new post, embed the previous post. await createNewPost();