-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TreeSelect component to Storybook #20496
Add TreeSelect component to Storybook #20496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your work on this @ediamin, it's looking good! 👍 I added a few notes below with some suggestions for minor improvements, let me know if you have any questions.
I also saw that it failed the storybook unit test, this usually just happens because the snapshot needs to be updated to include the new story. If you run npm run test-unit storybook/
it should take care of generating the new snapshot.
@brentswisher Thanks for the tips. I've followd you select-control story and update mine. Please review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all looking great! The only thing that is holding it up is it looks like the snapshot is out of date (Due to auto-incrementing ids, not anything you did) Do you think you can regenerate it and then it will be good to merge 👍
92a704a
to
3b08f48
Compare
@brentswisher Updated the snapshot. Please review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, the failing e2e test in Travis looks unrelated. Thanks for all your work @ediamin! 👏
Hi @brentswisher, is there anything else I should do? Just curious, why the PR is still been open even after you approved. |
I guess we just forgot about it :P. It happens. |
@youknowriad thanks! @ediamin I'm really sorry, I had restarted the tests to see if I could get them to pass and forgot to come back and check! Thanks for staying on top of it and for the help! |
Description
This PR add TreeSelect component to Storybook.
How has this been tested?
I've tested in my localhost running
npm run storybook:dev
.Screenshots
Types of changes
Checklist: