-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storybook story for Notice component #20545
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentswisher
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
February 28, 2020 20:07
8 tasks
Size Change: 0 B Total Size: 840 kB ℹ️ View Unchanged
|
brentswisher
force-pushed
the
add/notice-component-story
branch
from
March 2, 2020 17:38
257656c
to
a54e506
Compare
brentswisher
added
[Package] Components
/packages/components
Storybook
Storybook and its stories for components
labels
Mar 2, 2020
brentswisher
force-pushed
the
add/notice-component-story
branch
from
March 4, 2020 14:23
a54e506
to
41d7dd3
Compare
gziolo
approved these changes
Apr 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, I like the usage of knobs 👍
brentswisher
force-pushed
the
add/notice-component-story
branch
from
April 16, 2020 17:09
41d7dd3
to
1280b3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a storybook story for the Notice component as part of #17973
How has this been tested?
npm run storybook:dev
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)