[RNMobile] Adjust new borders implementations to columns PR #21073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 860 kB ℹ️ View Unchanged
|
jbinda
reviewed
Mar 23, 2020
There was a problem hiding this comment.
I have checked the code and test on demo app. It is huge improvement about usage and brings a lot of benefits - specially in long term.
I have also left some comments with minor adjustments (discussed on a call already). Hope we will be able to merge those changes soon ! :)
packages/block-editor/src/components/block-list/block.native.scss
Outdated
Show resolved
Hide resolved
Comment on lines
+43
to
+45
| if ( columnsInRow > 1 ) { | ||
| const margins = columnsInRow * 2 * styles.columnMargin.marginLeft; | ||
| width = ( minWidth - margins ) / Math.max( 1, columnsInRow ); |
There was a problem hiding this comment.
I have checked and this also works for more than 2 columnsInRow.
However we need to implement ideal version of FloatingToolbar because it breaks the layout when there is no enough space (it has minWIdth and the Column container is stretch to this sizes - see below screen). It's not something we need to change here just as reminder)
Unselected Columns layout
Selected Column with broken Columns layout
Selected Column with proper Columns layout after disable FloatingToolbar
There was a problem hiding this comment.
Yes it's known issue and exists also in buttons block
6 tasks
jbinda
reviewed
Mar 25, 2020
jbinda
added
[Block] Columns
jbinda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings adjustments need to allow using new bordering logic inside Column Block.
Please refer to:
Original refactoring PR
Column Block PR
design note
Builds for testing:
iOS: IPA 25710
Andorid: APK 42426 (please note one issue commented here)
How has this been tested?
Checking all Column Block PR testing requirements (see Column PR description)
During those checks please keep attention to how border is changing and see if there is no "jumping" during selection change
Types of changes
Refactor - Change the way how blocks bordering style is applied.
List of changes:
Checklist: