Fix panel collapsing in navigation page #21633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
requested review from
draganescu,
adamziel,
karmatosed,
noisysocks and
tellthemachines
6 tasks
|
Size Change: +98 B (0%) Total Size: 840 kB
ℹ️ View Unchanged
|
I'd give |
|
@tellthemachines Nice solution! I managed to get it working on IE11 as well: The only thing missing is the grid gap between the columns, which I don't think is supported in the old IE syntax. |
This reverts commit 25b0026612be3063a2d7ed208f7dd1f0cda25b03.
talldan
force-pushed
the
fix/navigation-page-panel-collapsing
branch
from
d0b412f to
5a769e6
Compare
Hmm, autoprefixer should be smart enough to handle that. Either we're not on the latest version or perhaps we don't have advanced grid support turned on; either way, sounds like something fixable (in a separate issue). |
tellthemachines
approved these changes
Apr 16, 2020
|
|
||
| .edit-navigation-menu-editor__navigation-structure-panel { | ||
| // IE11 requires the column to be explicity declared. | ||
| grid-column: 1; |
There was a problem hiding this comment.
Thanks, I always forget about this bit 😅
6 tasks
|
Oops, this accidentally broke things on mobile. #21638 makes good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently on the navigation page (at desktop breakpoints), when collapsing a panel, instead of the panel completely collapsing, only the content collapses and the panel itself remains the height of its grid row.
The reason for this is that the
Panelcomponents are currently displayed as grid columns, and in the grid the columns are always the same height, so if there's content in the right hand panel, the left hand panel assumes the same height.This PR fixes things by wrapping the panels in a
<div>. Thesedivs become the grid columns allowing thePanelsto collapse if needed.There might be a better way to do this without resorting to extra
divs, I'm open to ideas 😄 .How has this been tested?
Screenshots
Before
After
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: