Add '@' button for inserting mentions on mobile #21651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchowning
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
2 tasks
ceyhun
reviewed
Apr 21, 2020
mchowning
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
On Android we are discarding selections when we think they might get stripped by Aztec, so adding the space to the ends results in the selection values getting discarded.
# Conflicts: # packages/components/src/index.native.js
cameronvoell
approved these changes
May 8, 2020
There was a problem hiding this comment.
Changes here look good! 👍
I did find one very, very small issue. I think it could be logged and saved for later, but I'll leave a video here in case you would like to address now. Basically hitting back button after adding a mention, only when there is not a space before the mention will leave the cursor in the wrong location. See gif. If there is a space before the mention (which seems like it will be the more popular case), the back button leaves the cursor in the correct spot.
|
|
||
| onSelectionChange( index, index ); | ||
| onSelectionChange( this.selectionStart, this.selectionEnd ); |
There was a problem hiding this comment.
Curious if this is related to mentions or if there is a specific case that this update is addressing? @SergioEstevao
There was a problem hiding this comment.
When doing insert of the mentions we found a crash. It was related to the edge case where those indexes were set to NaN and then send to iOS native view.
That didn't like it and make it crash, I think this new code brought this edge case up and so I did this fix.
There was a problem hiding this comment.
Makes sense, thanks for the explanation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an
@button for inserting mentions on mobile (wordpress-mobile/gutenberg-mobile#331).How has this been tested?
RichText-based block.@button on the far right of the format toolbarChecklist: