Minor updates to @wordpress/edit-widgets for easier Core integration #26136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
the
[Feature] Widgets Screen
noisysocks
requested review from
adamziel,
draganescu,
ellatrix,
kevin940726,
spacedmonkey,
talldan,
tellthemachines,
TimothyBJacobs and
youknowriad
as code owners
|
Size Change: -16 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
|
Testing the plugin without the Core changes, item 3 is causing problems with the legacy widget previews. Instead of previewing the widget, the previews are rendering the widgets screen and throwing the browser into a loop which crashes it after a while. Is it not possible at all to use the plain site URL in Core? |
|
Hey @tellthemachines thanks for testing. I improved how the plugin handles the I'd really prefer to do it this way as it lets us, in Core, keep all of the logic for handling this param nice and compartmentalised in |
tellthemachines
approved these changes
Oct 15, 2020
draganescu
deleted the
update/edit-widgets-for-easier-core-integration
branch
tellthemachines
pushed a commit
that referenced
this pull request
Oct 15, 2020
…26136) * Widgets editor: Reset .widgets-php styling * Widgets editor: Register blocks in all Gutenberg phases * Widgets editor: Use ?widget-preview= instead of /?widgetPreview= * Widgets editor: Remove hasPermissionsToManageWidgets * Widget editor: Fix handling of widget-preview param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four smallish changes which will make it easier to add this package to Core (see WordPress/wordpress-develop#603).
Update the CSS to target
body.widgets-phpas well asbody.appearance_page_gutenberg-widgets. This is the class name that the screen will have in Core.Have
@wordpress/edit-widgetsregister the Legacy Widget block and the Widget Area block whenGUTENBERG_PHASEis 1. This prevents those blocks from not being registered in Core.Use
example.com/wp-admin/widgets.php?widget-preview=instead ofexample.com/?widgetPreview=for Legacy Widget block previewing. This means that the code for handling this query param can be co-located with the rest ofwidgets.phpin Core.Remove
hasPermissionsToManageWidgets. This isn't necessary as the Legacy Widget block is only ever registered in the widgets editor which can only be accessed when the logged-in user has permission to customise the site.I've tested this by copying the built packages over into Core and running it against my WIP integration branch (WordPress/wordpress-develop#603).
Need to test that these changes do not cause any regressions in the plugin, though.