Components: Expose composite API from Reakit #28085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Package] Components
youknowriad
reviewed
Jan 11, 2021
|
Size Change: -21.2 kB (-2%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
There is also usage of Not sure what to do about it though. Maybe expose as unstable from |
gziolo
force-pushed
the
update/reakit-composite
branch
from
73b6cd3 to
6a6293a
Compare
|
I opened #28095 that adds ESLint checks that will prevent the direct |
gziolo
force-pushed
the
update/reakit-composite
branch
from
6a6293a to
ebea6a4
Compare
gziolo
requested review from
adamziel,
ajitbohra,
chrisvanpatten,
draganescu,
ellatrix,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
gziolo
force-pushed
the
update/reakit-composite
branch
from
ebea6a4 to
651d7f7
Compare
gziolo
force-pushed
the
update/reakit-composite
branch
from
651d7f7 to
ed22350
Compare
|
This PR should be ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR explores how we could stop duplicating bundled code from Reakit:
It's based on the discussion that started with my own comment #28013 (comment). The idea comes from @youknowriad who proposed we expose shared APIs as part of
@wordpress/components.TODO
How has this been tested?
Screenshots
Types of changes
Checklist: